RFR: publish: rename --follow to --browse [v2]

Robin Westberg rwestberg at openjdk.java.net
Fri Sep 4 08:51:46 UTC 2020


On Fri, 4 Sep 2020 08:49:23 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please rename this patch that renames the flag `--follow` to `--browse` for `git-publish` to make its meaning more
>> clear.
>> Thanks,
>> Erik
>
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix spelling
>   
>   Co-authored-by: Robin Westberg <robin at westberg.se>

Looks good, just one spelling fix!

cli/src/main/java/org/openjdk/skara/cli/GitPublish.java line 147:

> 145:             Switch.shortcut("")
> 146:                   .fullname("browse")
> 147:                   .helptext("Open link returend by remote in web browser")

Suggestion:

                  .helptext("Open link returned by remote in web browser")

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/775


More information about the skara-dev mailing list