RFR: jcheck: remove unused code

Robin Westberg rwestberg at openjdk.java.net
Tue Sep 8 12:12:17 UTC 2020


On Tue, 8 Sep 2020 12:06:02 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that removes some very old code in `JCheck` that has never been used and just clutters the
> `JCheck` API. We have other ways of ensuring whether a certain commit should or should not be allowed to be pushed, the
> code that this patch removes is not used.  This is a fully backwards compatible change with both older and newer
> .jcheck/conf files.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] `make images` passes on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/805


More information about the skara-dev mailing list