RFR: vcs: do not hard-code VCS default branch names

Robin Westberg rwestberg at openjdk.java.net
Tue Sep 8 13:21:58 UTC 2020


On Tue, 8 Sep 2020 13:16:08 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that ensures that we don't hard-code the name of the default branches for various version
> control system throughout the Skara source code. Skara has from the beginning been very strict about abstracting away
> VCS implementation details, but the name of the default branches has managed to find its way into multiple corners of
> the source code.  Testing:
> - [x] `make test` passes on Linux x64
> - [x] `make images` passes on Linux x64
> 
> Thanks,
> Erik

Looks good, thanks for fixing!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/806


More information about the skara-dev mailing list