RFR: Treat bad whitespace in commit message gracefully [v2]

Erik Helin ehelin at openjdk.java.net
Fri Sep 11 07:20:49 UTC 2020


On Fri, 11 Sep 2020 07:17:30 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line
>> summaries to help avoid this problem in the first place.
>> Best regards,
>> Robin
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated after review

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 211:

> 209:         } else {
> 210:             desc = "a tab";
> 211:         }

Suggestion:

        } else if (issue.kind() == MessageWhitespaceIssue.Whitespace.TAB) {
            desc = "a tab";
        } else {
            throw new IllegalStateException("Unknown whitespace: " + issue.kind());
        }

-------------

PR: https://git.openjdk.java.net/skara/pull/814


More information about the skara-dev mailing list