RFR: Set or update the resolved in build field when new tags arrive

[Erik Helin]

On Mon, 14 Sep 2020 12:10:14 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When the issue notifier is configured to set a build name when resolving issues, it should also update that name when
> an OpenJDK-formatted tag is seen in the repository.

Looks good, just spell out "rib" in two places ��

bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/BuildCompare.java line 40:

> 38:     }
> 39:
> 40:     // Notable values for rib are 'team', 'master', and numbered builds

Suggestion:

    // Notable values for "Resolved in Build" are 'team', 'master', and numbered builds

bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 296:

> 294:                 var optionalIssue = issueProject.issue(commitIssue.shortId());
> 295:                 if (optionalIssue.isEmpty()) {
> 296:                     log.severe("Cannot update RIB for issue " + commitIssue.id()

Suggestion:

                    log.severe("Cannot update "Resolved in Build" for issue " + commitIssue.id()

-------------

Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/817