RFR: 673: PR author should be able to use /reviewers command

Kevin Rushforth kcr at openjdk.java.net
Mon Sep 14 16:28:17 UTC 2020

On Mon, 14 Sep 2020 16:03:01 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author
> knows ahead of time that it is a complicated to PR to review).
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added one additional unit test
> Thanks,
> Erik

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 52:

> 50:     @Override
> 51:     public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, Path scratchPath,
> CommandInvocation command, List<Comment> allComments, PrintWriter reply) { 52:         if
> (!pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) {

This would suggest that my assumption is wrong, and that an author can reduce the number of reviewers required even if
they are not a Reviewer. I think this might not be what we want.


PR: https://git.openjdk.java.net/skara/pull/820

More information about the skara-dev mailing list