RFR: 673: PR author should be able to use /reviewers command

Kevin Rushforth kcr at openjdk.java.net
Mon Sep 14 21:16:56 UTC 2020

On Mon, 14 Sep 2020 20:18:10 GMT, Phil Race <prr at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 52:
>>> 50:     @Override
>>> 51:     public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, Path scratchPath,
>>> CommandInvocation command, List<Comment> allComments, PrintWriter reply) { 52:         if
>>> (!pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) {
>> This would suggest that my assumption is wrong, and that an author can reduce the number of reviewers required even if
>> they are not a Reviewer. I think this might not be what we want.
> I think it is fine to let them increase it.

Agreed. It's the case of an author reducing it after a Reviewer has increased it that I think should be disallowed.


PR: https://git.openjdk.java.net/skara/pull/820

More information about the skara-dev mailing list