RFR: 673: PR author should be able to use /reviewers command [v3]

Kevin Rushforth kcr at openjdk.java.net
Tue Sep 15 12:57:01 UTC 2020

On Tue, 15 Sep 2020 09:47:03 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author
>> knows ahead of time that it is a complicated to PR to review).
>> Testing:
>> - [x] `make test` passes on Linux x64
>> - [x] Added one additional unit test
>> Thanks,
>> Erik
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>   Simplify code based on reviewer feedback

Looks good with one minor suggestion (feel free to ignore it).

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 111:

> 109:         }
> 110:
> 111:         if (pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) {

Maybe simplify this to just `! isReviewer`? Including the test for `is author` doesn't really add value (removing it
seems to better reflect the intent and might be safer / more future proof).


Marked as reviewed by kcr (no project role).

PR: https://git.openjdk.java.net/skara/pull/820

More information about the skara-dev mailing list