Missing metadata removal in jdk commit
Erik Helin
erik.helin at oracle.com
Wed Sep 16 10:24:30 UTC 2020
On 9/15/20 7:44 PM, Florian Weimer wrote:
> I see this in the commit history:
>
> commit 7eb4d4aa018e37052cbf37cd854380006c309645
> Author: Kim Barrett <kbarrett at openjdk.org>
> Date: Tue Sep 15 10:52:50 2020 +0000
>
> 8247909: Improve PrimitiveConversions::cast using C++14
>
> Reimpliment PrimitiveConversions::cast, with some cases now constexpr.
> <!-- Anything below this marker will be automatically updated, please do not edit manually! -->
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> - [x] Commit message must refer to an issue
> - [ ] Change must be properly reviewed
>
> ### Issue
> * [JDK-8247909](https://bugs.openjdk.java.net/browse/JDK-8247909): Improve PrimitiveConversions::cast using C++14
>
>
> ### Download
> `$ git fetch https://git.openjdk.java.net/jdk pull/143/head:pull/143`
> `$ git checkout pull/143`
>
> Reviewed-by: dholmes, stefank
>
> I don't think it makes sense to preserve this information in the Git
> history, and the SGML comment suggests that it's expected to be
> stripped.
Yeah, I noticed this yesterday too, it is a bug. Fixed in [0].
Thanks,
Erik
[0]: https://git.openjdk.java.net/skara/pull/825
More information about the skara-dev
mailing list