RFR: 690: Merge commit message is not Merge jdk, but: Merge jdk

Robin Westberg rwestberg at openjdk.java.net
Fri Sep 18 08:52:53 UTC 2020


On Fri, 18 Sep 2020 08:48:42 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that makes it more clear what the expected and current commit messages are when showing the
> error for `MergeMessageCheck`.
> Thanks,
> Erik

Looks good, just one comment!

.jcheck/conf line 44:

> 42:
> 43: [checks "merge"]
> 44: message=Merge jdk

Do we really want this check for Skara? :)

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/831


More information about the skara-dev mailing list