RFR: 716: Git version check pattern matching is too strict

Thomas Stuefe stuefe at openjdk.java.net
Tue Sep 22 05:05:22 UTC 2020


Hi,

may I have reviews please for this small fix. On my Ubuntu 16.4 box I run with git 2.7.0 (so far without any problems,
but that is another story). Skara wants a newer version and does a version check. That check fails to parse the version
number correctly.

https://bugs.openjdk.java.net/browse/SKARA-716

Tests: tried to run gradlw test on my Linux box but I get test errors - but those errors also appear on a clean repo
(see https://mail.openjdk.java.net/pipermail/skara-dev/2020-September/003410.html), I am quite sure they have anything
to do with my fix.

-------------

Commit messages:
 - 716: Git version check pattern matching is too strict

Changes: https://git.openjdk.java.net/skara/pull/838/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=838&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-716
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/838.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/838/head:pull/838

PR: https://git.openjdk.java.net/skara/pull/838


More information about the skara-dev mailing list