RFR: 716: Git version check pattern matching is too strict

Erik Helin ehelin at openjdk.java.net
Tue Sep 22 09:41:45 UTC 2020

On Tue, 22 Sep 2020 09:39:04 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi,
>> may I have reviews please for this small fix. On my Ubuntu 16.4 box I run with git 2.7.0 (so far without any problems,
>> but that is another story). Skara wants a newer version and does a version check. That check fails to parse the version
>> number correctly.   https://bugs.openjdk.java.net/browse/SKARA-716
>> Tests: tried to run gradlw test on my Linux box but I get test errors - but those errors also appear on a clean repo
>> (see https://mail.openjdk.java.net/pipermail/skara-dev/2020-September/003410.html), I am quite sure they have anything
>> to do with my fix.
> Looks good!

@tstuefe the tests are failing because you have a too old Mercurial version.


PR: https://git.openjdk.java.net/skara/pull/838

More information about the skara-dev mailing list