Errors when running jcheck locally

[Erik Helin]

On 9/22/20 12:55 PM, Volker Simonis wrote:
> Hi,
> 
> sorry if this has been documented or answered already somewhere but I
> couldn't find any information in the WIki or the mailing list.
> 
> I think I have a valid setup and configured everything properly, but
> when I run "git jcheck" locally on my clone of a
> https://github.com/openjdk/jdk fork, I get the following errors:
> 
> $ git status
> On branch JDK-8253435-cpusets-fix
> $ git log
> commit 568c48964a156f5ca71319f0585f2d5c84899c62 (HEAD ->
> JDK-8253435-cpusets-fix)
> Author: Volker Simonis <volker.simonis at gmail.com>
> Date:   Mon Sep 21 18:58:58 2020 +0200
> 
>      8253435: Cgroup: 'stomping of _mount_path' crash if manually
> mounted cpusets exist
> ...
> $ git jcheck
> [branches] error: illegal branch name: JDK-8253435-cpusets-fix
> [branches] error: illegal branch name: zip_entry_fix
> [committer] error: 568c4896: missing committer email from domain openjdk.org
> [committer] error: 568c4896: Volker Simonis is not committer in project jdk
> [reviewers] error: 568c4896: 1 reviewer required, found 0
> 
> The last error is valid because I have not entered any reviewers yet,
> but what about the other errors?

The branches error is because you have branches locally :) The upstream 
jdk repository does not allow any additional branches and jcheck can't 
know that it is being run in a contributor's local repository.

The committer error is because the values for `user.name` and 
`user.email` in your local git configuration isn't following the JEP 357 
conventions.

> Isn't jcheck intended to be run locally?

It certainly is! git-jcheck has the flag --ignore which lets you ignore 
errors from a particular check. Any error printed by git-jcheck is 
always prefixed with the check that found the error (in your case the 
branches, committer and reviewers checks).

I would argue that you can safely ignore all errors from the branches, 
committer and reviewers checks because:

- you cannot create a new branch in the upstream jdk repository since
   you don't direct write access.
- the committer field in the final commit will be set by the Skara bots
   and they will use the right values. Whatever you have configured
   locally does not matter.
- since the commit is _not_ out for review yet you can't have any
   reviewers.

To always ignore errors from the branches, committer and reviewers 
checks, just run:

    $ git config --global jcheck.ignore branches,committer,reviewers

Thanks,
Erik

> Thank you and best regards,
> Volker
>