RFR: 685: Show a warning if PR author's full name does not match commit author's full name

Robin Westberg rwestberg at openjdk.java.net
Wed Sep 23 07:59:14 UTC 2020


On Tue, 22 Sep 2020 16:12:07 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds an error if the author of the pull request does not have an OpenJDK username, has a
> full name set for their GitHub account and the `HEAD` commit for the pull request uses another full name.
> Testing:
> - [x] `make test` passes on Linux x64
> - [x] Added an additional unit test
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/840


More information about the skara-dev mailing list