Large webrevs do not show up

Thomas Stüfe thomas.stuefe at gmail.com
Thu Sep 24 15:29:30 UTC 2020


Hi Jim!

I assume you mean a timeout during webrev generation? Possibly. Generating
the webrev by hand certainly takes a long time.

Cheers, Thomas

On Thu, Sep 24, 2020 at 4:07 PM Jim Laskey <james.laskey at oracle.com> wrote:

> Is it a timeout issue loading the data?
>
>
> webrev.js:1491
>
> const setup = init();
> window.onload = async function(e) {
>         await setup;
>    << Unhandled Promise Rejection: SyntaxError: The string did not match
> the expected pattern.
>         log("onload: fragment: " + window.location.hash);
>         renderFromFragment(window.location.hash);
> }
>
>
> > On Sep 24, 2020, at 10:53 AM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
> >
> > Okay, I opened https://bugs.openjdk.java.net/browse/SKARA-732 to track
> this
> > issue.
> >
> > Cheers, Thomas
> >
> > On Thu, Sep 24, 2020 at 3:33 PM Thomas Stüfe <thomas.stuefe at gmail.com>
> > wrote:
> >
> >> Hi all,
> >>
> >> I just posted a PR for jep387:
> >>
> >>
> >>
> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-September/042203.html
> >>
> >> and the webrev is not displayed. I tried several browsers on several
> >> machines. The patch is rather large. Did I hit a limit with github?
> >>
> >> Thanks, Thomas
> >>
>
>


More information about the skara-dev mailing list