RFR: forge: add search method

Robin Westberg rwestberg at openjdk.java.net
Tue Sep 29 15:38:09 UTC 2020


On Tue, 29 Sep 2020 14:12:29 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java line 246:
>> 
>>> 244:                                   .collect(Collectors.toList());
>>> 245:             for (var project : projects) {
>>> 246:                 var c = request.get("projects/" + project + "/repository/commits/" + hex)
>> 
>> Could we use this endpoint instead? https://docs.gitlab.com/ce/api/commits.html#get-a-single-commit
>
> That is the endpoint the code is using �� Did you perhaps miss the `+ hex` part?

Well then, carry on!

-------------

PR: https://git.openjdk.java.net/skara/pull/854


More information about the skara-dev mailing list