RFR: Backport security level should be inherited from main issue

Kevin Rushforth kcr at openjdk.java.net
Thu Apr 8 21:00:41 UTC 2021

On Thu, 8 Apr 2021 20:30:39 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This is a change Robin prepared, but we need to deploy it ASAP to match the new behavior in the backport plugin after the Jira upgrade. The security level of a backport should simply be based on the security level of the primary bug.

Looks good to me (although I am not a Skara project Reviewer).

bots/notify/src/test/java/org/openjdk/skara/bots/notify/issue/IssueNotifierTests.java line 1069:

> 1067:             if (level != null) {
> 1068:                 assertEquals(level.asString(), backport.properties().get("security").asString());
> 1069:             }

Maybe also worth also checking that if level is null, the returned property is empty? This could be done as a follow-up given the need to get this in right away.


Marked as reviewed by kcr (no project role).

PR: https://git.openjdk.java.net/skara/pull/1110

More information about the skara-dev mailing list