RFR: 963: Skara mlbridge bot sometimes resends old messages [v3]

[Erik Joelsson]

On Wed, 14 Apr 2021 11:55:27 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Avoid parsing the sent mail archive into conversations as we're only interested in the IDs that we have already sent.
>
> Robin Westberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into mlbridge_archive_parse
>  - Do not try to parse sent mails as a conversation as we just want the ID's
>  - Fix build error after merge
>  - Merge remote-tracking branch 'upstream/master' into mbox_crosspost
>  - Rename MailingList -> MailingListReader
>  - Fix configuration parsing
>  - Add support for treating a set of mboxes as a single source of conversations
>  - Improve mbox parsing

bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java line 251:

> 249:             var archiveContents = Files.readString(mboxBasePath.resolve(pr.id() + ".mbox"), StandardCharsets.UTF_8);
> 250:             sentMails.addAll(Mbox.splitMbox(archiveContents, bot.emailAddress()));
> 251:         } catch (IOException ignored) {

Shouldn't we at least log this?

-------------

PR: https://git.openjdk.java.net/skara/pull/1117