RFR: 934: Bots incorrectly assigned "build" label despite no obvious matching rule

Erik Joelsson erikj at openjdk.java.net
Wed Apr 14 17:06:30 UTC 2021


On Wed, 14 Apr 2021 15:24:22 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When determining the set of file names to evaluate for determining label assignment, only include the source name for deletions and renames (and not for copies, for example).

Marked as reviewed by erikj (Reviewer).

So in the PR listed in the bug, it was most likely this new file that Git implicitly assumed was a copy of an existing plist file because the initial content looked similar enough. We have such plist files under build directories so that's why the build label was added. Sneaky.

src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/sandbox.plist

-------------

PR: https://git.openjdk.java.net/skara/pull/1118


More information about the skara-dev mailing list