[cr] RFR: 667: Webrev contents broken for rebased push

Erik Helin ehelin at openjdk.java.net
Thu Apr 15 13:57:46 UTC 2021


Hi all,

please review this patch that makes `webrev.js` calculate the "base"/"old" content from the "head"/"new" content and the reversed patch. This make `webrev.js` handle webrevs for force pushes. I also took the opportunity to reduce the number of network requests (by half) and also parallelized the initial three network requests.

Testing:
- [x] Manual testing on a large number of webrevs

Thanks,
Erik

-------------

Commit messages:
 - Create base content from head content

Changes: https://git.openjdk.java.net/cr/pull/10/files
 Webrev: https://webrevs.openjdk.java.net/?repo=cr&pr=10&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-667
  Stats: 111 lines in 1 file changed: 56 ins; 43 del; 12 mod
  Patch: https://git.openjdk.java.net/cr/pull/10.diff
  Fetch: git fetch https://git.openjdk.java.net/cr pull/10/head:pull/10

PR: https://git.openjdk.java.net/cr/pull/10


More information about the skara-dev mailing list