[cr] RFR: 667: Webrev contents broken for rebased push

Robin Westberg rwestberg at openjdk.java.net
Thu Apr 15 14:15:50 UTC 2021

On Thu, 15 Apr 2021 13:54:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that makes `webrev.js` calculate the "base"/"old" content from the "head"/"new" content and the reversed patch. This make `webrev.js` handle webrevs for force pushes. I also took the opportunity to reduce the number of network requests (by half) and also parallelized the initial three network requests.
> Testing:
> - [x] Manual testing on a large number of webrevs
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/cr/pull/10

More information about the skara-dev mailing list