[cr] Integrated: index.html: inline js

Erik Helin ehelin at openjdk.java.net
Fri Apr 16 08:54:48 UTC 2021


Hi all,

please review this patch that inlines `webrev.js` into `index.html` to avoid an additional network request. It would have been better to keep the JS in a separate file if we could:

- minify the JS
- configure cache control headers

GitHub Pages unfortunately does not allow any of the above (and we don't want a build step for minification), therefore the best option is to inline the JS into `index.html`.

Thanks,
Erik

-------------

Commit messages:
 - Fix trailing whitespace
 - index.html: inline js

Changes: https://git.openjdk.java.net/cr/pull/13/files
 Webrev: https://webrevs.openjdk.java.net/?repo=cr&pr=13&range=00
  Stats: 3034 lines in 2 files changed: 1506 ins; 1528 del; 0 mod
  Patch: https://git.openjdk.java.net/cr/pull/13.diff
  Fetch: git fetch https://git.openjdk.java.net/cr pull/13/head:pull/13

PR: https://git.openjdk.java.net/cr/pull/13


More information about the skara-dev mailing list