RFR: 980: Update log level of thrown exceptions

Robin Westberg rwestberg at openjdk.java.net
Wed Apr 21 06:44:37 UTC 2021

On Tue, 20 Apr 2021 21:59:06 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch updates (almost) all uses of log.throwing() to log.log() so that we can include any exception in a log message of the appropriate level. This became necessary as we started logging each log message individually to logstash, so the FINER level logs from log.throwing() were no longer included. 
> In addition to this, I'm also adding stack_trace and logger_name as fields in the logstash logging entries.

Looks good!

bot/src/main/java/org/openjdk/skara/bot/BotRunner.java line 170:

> 168:                         head.get();
> 169:                     } catch (InterruptedException | ExecutionException e) {
> 170:                         log.log(Level.WARNING,"Exception during queue drain", e);


                        log.log(Level.WARNING, "Exception during queue drain", e);


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1132

More information about the skara-dev mailing list