RFR: 941: Warn about required merge after dependent PR integration

Erik Joelsson erikj at openjdk.java.net
Thu Apr 22 16:20:20 UTC 2021


On Thu, 22 Apr 2021 13:33:55 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When a dependent PR has been integrated, post an instructional message on how to merge these changes.

Marked as reviewed by erikj (Reviewer).

bots/notify/src/main/java/org/openjdk/skara/bots/notify/prbranch/PullRequestBranchNotifier.java line 86:

> 84:                     has been updated. This means that changes from the dependent pull request can start to show up \
> 85:                     as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, \
> 86:                     simply merge the latest changes from the target branch into this pull request by running commands \

Suggestion:

                    simply merge the latest changes from the new target branch into this pull request by running commands \

-------------

PR: https://git.openjdk.java.net/skara/pull/1134


More information about the skara-dev mailing list