[cr] RFR: 988: Skara webrev is empty if patch has deleted files [v2]
Erik Joelsson
erikj at openjdk.java.net
Fri Apr 23 20:17:33 UTC 2021
On Fri, 23 Apr 2021 09:39:58 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adjusted for review comments
>
> index.html line 1521:
>
>> 1519: } else if (line.startsWith("\\ No newline at end of file")) {
>> 1520: continue;
>> 1521: } else if (line == "") {
>
> Perhaps use `===`?
That seems to be the standard in this project, so ok, changing it. I think verifying type seems unnecessary here though. The relevance of the test is to see if line resolves to an empty string.
-------------
PR: https://git.openjdk.java.net/cr/pull/14
More information about the skara-dev
mailing list