[cr] Integrated: 988: Skara webrev is empty if patch has deleted files

Erik Joelsson erikj at openjdk.java.net
Tue Apr 27 13:44:43 UTC 2021

On Thu, 22 Apr 2021 21:35:43 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> If a file in the patch has been deleted this causes a dereference of an undefined value. To fix this I removed the quick return in fetchFileContent so that this function always returns a value.
> While verifying this, I also noted that the deleted file gets a Raw link which results in a 404. I think it should just not print the Raw link so I removed that too.
> If a file has only been renamed, with no other changes, the patch will be an empty string. This upsets the hunk loop, so I added a case for handling this.
> The resulting webrevs from the two reported patches look correct to me with these changes, but I would appreciate some more eyes on this.

This pull request has now been integrated.

Changeset: 629c501f
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/cr/commit/629c501fd20e7e546ec8fe08e35616fa6dfa6a0a
Stats:     8 lines in 1 file changed: 2 ins; 3 del; 3 mod

988: Skara webrev is empty if patch has deleted files

Reviewed-by: rwestberg, ehelin


PR: https://git.openjdk.java.net/cr/pull/14

More information about the skara-dev mailing list