Integrated: 983: Github commit links 404
Erik Joelsson
erikj at openjdk.java.net
Tue Apr 27 17:45:35 UTC 2021
On Thu, 22 Apr 2021 22:38:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> Sometimes our abbreviated commit web links on Github are not working. My guess is that this is caused by collisions. I think the correct fix here is to stop abbreviating commit hashes in links. Github internal links seem to always be full hashes, while pretty printing the link text with an abbreviation. We should adopt the same basic principle.
This pull request has now been integrated.
Changeset: 75a8a621
Author: Erik Joelsson <erikj at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/75a8a62156a425ceb689c4914578d3f7a54099f1
Stats: 79 lines in 4 files changed: 63 ins; 0 del; 16 mod
983: Github commit links 404
Reviewed-by: tbell, rwestberg, ehelin, kcr
-------------
PR: https://git.openjdk.java.net/skara/pull/1136
More information about the skara-dev
mailing list