From iklam at openjdk.java.net Fri Aug 6 05:30:40 2021 From: iklam at openjdk.java.net (Ioi Lam) Date: Fri, 6 Aug 2021 05:30:40 GMT Subject: RFR: 1123: mailing list rule for openjdk/src/hotspot/share/cds/ Message-ID: Changes in these files should be associated with the "hotspot-runtime" label. ------------- Commit messages: - 1123: mailing list rule for openjdk/src/hotspot/share/cds/ Changes: https://git.openjdk.java.net/skara/pull/1207/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1207&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1123 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/1207.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1207/head:pull/1207 PR: https://git.openjdk.java.net/skara/pull/1207 From iignatyev at openjdk.java.net Fri Aug 6 20:18:56 2021 From: iignatyev at openjdk.java.net (Igor Ignatyev) Date: Fri, 6 Aug 2021 20:18:56 GMT Subject: RFR: 1123: mailing list rule for openjdk/src/hotspot/share/cds/ In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 05:27:18 GMT, Ioi Lam wrote: > Changes in these files should be associated with the "hotspot-runtime" label. LGTM ------------- Marked as reviewed by iignatyev (no project role). PR: https://git.openjdk.java.net/skara/pull/1207 From kcr at openjdk.java.net Sat Aug 7 14:01:42 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Sat, 7 Aug 2021 14:01:42 GMT Subject: RFR: 1123: mailing list rule for openjdk/src/hotspot/share/cds/ In-Reply-To: References: Message-ID: <7H54Vq75-wh2YPwJveyW4hyUWeO802bIBp_mNLwOrpw=.6c04080b-cf4e-4fae-9195-fc295dba0d54@github.com> On Fri, 6 Aug 2021 05:27:18 GMT, Ioi Lam wrote: > Changes in these files should be associated with the "hotspot-runtime" label. Marked as reviewed by kcr (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/1207 From iklam at openjdk.java.net Sun Aug 8 18:12:15 2021 From: iklam at openjdk.java.net (Ioi Lam) Date: Sun, 8 Aug 2021 18:12:15 GMT Subject: RFR: 1123: mailing list rule for openjdk/src/hotspot/share/cds/ In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 20:16:29 GMT, Igor Ignatyev wrote: >> Changes in these files should be associated with the "hotspot-runtime" label. > > LGTM Thanks @iignatev and @kevinrushforth for the review. ------------- PR: https://git.openjdk.java.net/skara/pull/1207 From iklam at openjdk.java.net Mon Aug 9 12:32:34 2021 From: iklam at openjdk.java.net (Ioi Lam) Date: Mon, 9 Aug 2021 12:32:34 GMT Subject: Integrated: 1123: mailing list rule for openjdk/src/hotspot/share/cds/ In-Reply-To: References: Message-ID: On Fri, 6 Aug 2021 05:27:18 GMT, Ioi Lam wrote: > Changes in these files should be associated with the "hotspot-runtime" label. This pull request has now been integrated. Changeset: 9e1ba0e2 Author: Ioi Lam Committer: Kevin Rushforth URL: https://git.openjdk.java.net/skara/commit/9e1ba0e202dcb6259c27a9cb3bd5a182d051290d Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 1123: mailing list rule for openjdk/src/hotspot/share/cds/ Reviewed-by: iignatyev, kcr ------------- PR: https://git.openjdk.java.net/skara/pull/1207 From kcr at openjdk.java.net Mon Aug 9 18:16:52 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 9 Aug 2021 18:16:52 GMT Subject: RFR: 1111: Backport command needs better matching of target repo In-Reply-To: <5zpvudB5ePtwqGe6Afhffaiqa2y7V9FWrXXR8D4RiZM=.aef12434-9503-4efc-a7b2-cfe61c264129@github.com> References: <5zpvudB5ePtwqGe6Afhffaiqa2y7V9FWrXXR8D4RiZM=.aef12434-9503-4efc-a7b2-cfe61c264129@github.com> Message-ID: <2HJWE8G70lb1wa6jHJQIqqHk1LV9-H2cB3y7LI925YQ=.f728fcbe-3ad0-4757-bb0c-60f442c76b68@github.com> On Fri, 16 Jul 2021 11:01:48 GMT, Erik Joelsson wrote: > This patch improves the /backport commit command, making it smarter when trying to find the target repository from the argument given by the user. Instead of trying to piece it together based on the namespace (organization/group) of the current repository, it goes straight to the forks configuration and tries to match the repo from there. We can only do backports if there is a valid fork configuration anyway. > > In addition to this, I'm also changing the error message you get when you enter an invalid target repo. The list now includes the namespace prefix for each repo, and a note that supplying it is optional. This is a dummy comment to prevent auto-closure. ------------- PR: https://git.openjdk.java.net/skara/pull/1204 From kcr at openjdk.java.net Mon Aug 9 18:17:50 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 9 Aug 2021 18:17:50 GMT Subject: RFR: 1048: Missing integration comment causes mlbridge to throw exceptions In-Reply-To: <4JLVt1HtU-EPf72CyI_ddNzHU9UZ9_ERJBE8rTZucIY=.40c94aaf-a9a0-4323-8fcb-ab4caef555d6@github.com> References: <4JLVt1HtU-EPf72CyI_ddNzHU9UZ9_ERJBE8rTZucIY=.40c94aaf-a9a0-4323-8fcb-ab4caef555d6@github.com> Message-ID: On Fri, 16 Jul 2021 13:19:22 GMT, Erik Joelsson wrote: > This patch changes the mlbridge bot to stop throwing errors when it encounters a PR marked as integrated but without the integration comment (which contains the information about the commit hash needed for the email). Instead, it's just logged and no action is taken. When the comment is eventually added, the bot will run again and the email will be sent. > > The ordering of actions from the PR bot must unfortunately be like it is, with the comment added last. This is a dummy comment to prevent auto-closure. ------------- PR: https://git.openjdk.java.net/skara/pull/1205 From smohammedkan at openjdk.java.net Tue Aug 10 16:54:36 2021 From: smohammedkan at openjdk.java.net (Shahinshah Mohammed Kannu Rawther) Date: Tue, 10 Aug 2021 16:54:36 GMT Subject: RFR: 1128: mailing list thread comments aren't being registered in github PR Message-ID: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> Reverting changes of 1058 @kevinrushforth ------------- Commit messages: - 1128: mailing list thread comments aren't being registered in github PR Changes: https://git.openjdk.java.net/skara/pull/1208/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1208&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1128 Stats: 38 lines in 10 files changed: 18 ins; 9 del; 11 mod Patch: https://git.openjdk.java.net/skara/pull/1208.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1208/head:pull/1208 PR: https://git.openjdk.java.net/skara/pull/1208 From kcr at openjdk.java.net Tue Aug 10 17:11:26 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 10 Aug 2021 17:11:26 GMT Subject: RFR: 1128: mailing list thread comments aren't being registered in github PR In-Reply-To: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> References: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> Message-ID: On Tue, 10 Aug 2021 16:51:36 GMT, Shahinshah Mohammed Kannu Rawther wrote: > Reverting changes of 1058 @kevinrushforth I can confirm that this reverts the commit for [SKARA-1058](https://bugs.openjdk.java.net/browse/SKARA-1058). We need to file a REDO bug for SKARA-1058. ------------- Marked as reviewed by kcr (Reviewer). PR: https://git.openjdk.java.net/skara/pull/1208 From smohammedkan at openjdk.java.net Tue Aug 10 17:14:45 2021 From: smohammedkan at openjdk.java.net (Shahinshah Mohammed Kannu Rawther) Date: Tue, 10 Aug 2021 17:14:45 GMT Subject: Integrated: 1128: mailing list thread comments aren't being registered in github PR In-Reply-To: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> References: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> Message-ID: On Tue, 10 Aug 2021 16:51:36 GMT, Shahinshah Mohammed Kannu Rawther wrote: > Reverting changes of 1058 @kevinrushforth This pull request has now been integrated. Changeset: 47943b09 Author: Shahinshah Mohammed Kannu Rawther Committer: Kevin Rushforth URL: https://git.openjdk.java.net/skara/commit/47943b0960f1eb974fc09bf676b4b610bf0b2711 Stats: 38 lines in 10 files changed: 18 ins; 9 del; 11 mod 1128: mailing list thread comments aren't being registered in github PR Reviewed-by: kcr ------------- PR: https://git.openjdk.java.net/skara/pull/1208 From kcr at openjdk.java.net Tue Aug 10 17:17:43 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 10 Aug 2021 17:17:43 GMT Subject: RFR: 1128: mailing list thread comments aren't being registered in github PR In-Reply-To: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> References: <0C88RX95rqZ3MWEs3f_1RJuatXM3llS_wX-gMaXl2D0=.b1ee7aad-59a9-48ba-b709-71ecb49bde1d@github.com> Message-ID: <4262yEPVm7REDjDDDCGo8xY_bc8d7na3_-rKnpDo1ZA=.81388dab-312d-45b1-a922-a5e7f0cc070d@github.com> On Tue, 10 Aug 2021 16:51:36 GMT, Shahinshah Mohammed Kannu Rawther wrote: > Reverting changes of 1058 @kevinrushforth I filed [SKARA-1129](https://bugs.openjdk.java.net/browse/SKARA-1129) to redo the fix for [SKARA-1028](https://bugs.openjdk.java.net/browse/SKARA-1028). ------------- PR: https://git.openjdk.java.net/skara/pull/1208 From kevin.rushforth at oracle.com Tue Aug 10 18:51:21 2021 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 10 Aug 2021 11:51:21 -0700 Subject: [External] : Re: GitHub/Mailing list communication defunct? In-Reply-To: References: <095fc050-dbb1-107d-eac9-89c974ba42b8@oracle.com> <59dd2185-104f-3235-6d8a-5f581f6d99be@gmail.com> Message-ID: <35752964-122b-a857-9002-ea8d6e38ae27@oracle.com> [Moving jdk-dev to Bcc] Shah deployed a tentative fix for this about an hour ago. We hope this will resolve the problem. -- Kevin On 7/27/2021 10:44 AM, tim.bell at oracle.com wrote: > Hello > >> if someone comments/replies directly to the mailing list thread (like >> Bernd and I did, during this past hour[2]), those comments aren't >> being registered in that github PR. This used to work previously and >> seems to be broken right now. > > We are aware of this problem and still investigating.? We don't have a > root cause or an ETA for this. > > Tim > > > On 7/22/21 09:21, Jaikiran Pai wrote: >> FWIW, it looks like this isn't fully back to normal. From what I can >> see in one of the PR's[1] I'm involved in, if I comment directly on >> the PR through the github UI, a mail is now getting delivered to the >> relevant mailing lists. So this part is back to normal now. >> >> However, if someone comments/replies directly to the mailing list >> thread (like Bernd and I did, during this past hour[2]), those >> comments aren't being registered in that github PR. This used to work >> previously and seems to be broken right now. >> >> [1] >> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/4607__;!!ACWV5N9M2RV99hQ!eNjD04SNNH9INHTt0cyyed12lRNw9aZfSspNKh0ILIUQCIcvka-_vJ8XHXipGIQ$ >> >> [2] >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079994.html >> >> >> -Jaikiran >> >> On 22/07/21 3:03 am, tim.bell at oracle.com wrote: >>>> just recognized that all of a sudden the traffic on the OpenJDK >>>> mailing lists dropped >>> >>> About an hour ago we corrected a problem on the Skara server >>> processing external (EG: github) messages.? Message traffic should >>> be flowing again. >>> >>> Messages for events during the outage are lost.? We will be holding >>> a port-mortem to investigate why this outage was not noticed sooner, >>> and why there was a data loss. >>> >>> Tim >>> >>> >>> On 7/21/21 14:29, David Holmes wrote: >>>> Hi Christoph, >>>> >>>> On 22/07/2021 1:07 am, Langer, Christoph wrote: >>>>> Hi, >>>>> >>>>> there's still no traffic on the mailing lists... >>>>> >>>>> It would be much appreciated if you could share an update on the >>>>> status. >>>> >>>> There was no update to share I'm afraid but it has now been resolved. >>>> >>>> It seems likely that the missing mail is gone forever unfortunately. >>>> >>>> Cheers, >>>> David >>>> >>>>> Thanks >>>>> Christoph >>>>> >>>>> From: Langer, Christoph >>>>> Sent: Dienstag, 20. Juli 2021 08:23 >>>>> To: ops at openjdk.java.net; skara-dev at openjdk.java.net; >>>>> jdk-dev at openjdk.java.net >>>>> Subject: GitHub/Mailing list communication defunct? >>>>> >>>>> Hi, >>>>> >>>>> I just recognized that all of a sudden the traffic on the OpenJDK >>>>> mailing lists dropped... First I thought it's an issue with my >>>>> account but looking at the pipermail archives, I don't find any >>>>> mails after e.g. some time yesterday. And I guess there's still >>>>> the usual activity on GitHub... >>>>> >>>>> Are you aware of an issue? >>>>> >>>>> Thanks & Best regards >>>>> Christoph >>>>> >>> >> > From david.holmes at oracle.com Thu Aug 12 00:03:49 2021 From: david.holmes at oracle.com (David Holmes) Date: Thu, 12 Aug 2021 10:03:49 +1000 Subject: [External] : Re: GitHub/Mailing list communication defunct? In-Reply-To: References: <095fc050-dbb1-107d-eac9-89c974ba42b8@oracle.com> <59dd2185-104f-3235-6d8a-5f581f6d99be@gmail.com> Message-ID: Just FYI the problem is still under investigation and still seems to persist for some ML's but not all. David On 28/07/2021 3:44 am, tim.bell at oracle.com wrote: > Hello > >> if someone comments/replies directly to the mailing list thread (like >> Bernd and I did, during this past hour[2]), those comments aren't >> being registered in that github PR. This used to work previously and >> seems to be broken right now. > > We are aware of this problem and still investigating.? We don't have a > root cause or an ETA for this. > > Tim > > > On 7/22/21 09:21, Jaikiran Pai wrote: >> FWIW, it looks like this isn't fully back to normal. From what I can >> see in one of the PR's[1] I'm involved in, if I comment directly on >> the PR through the github UI, a mail is now getting delivered to the >> relevant mailing lists. So this part is back to normal now. >> >> However, if someone comments/replies directly to the mailing list >> thread (like Bernd and I did, during this past hour[2]), those >> comments aren't being registered in that github PR. This used to work >> previously and seems to be broken right now. >> >> [1] >> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/4607__;!!ACWV5N9M2RV99hQ!eNjD04SNNH9INHTt0cyyed12lRNw9aZfSspNKh0ILIUQCIcvka-_vJ8XHXipGIQ$ >> >> [2] >> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079994.html >> >> >> -Jaikiran >> >> On 22/07/21 3:03 am, tim.bell at oracle.com wrote: >>>> just recognized that all of a sudden the traffic on the OpenJDK >>>> mailing lists dropped >>> >>> About an hour ago we corrected a problem on the Skara server >>> processing external (EG: github) messages.? Message traffic should be >>> flowing again. >>> >>> Messages for events during the outage are lost.? We will be holding a >>> port-mortem to investigate why this outage was not noticed sooner, >>> and why there was a data loss. >>> >>> Tim >>> >>> >>> On 7/21/21 14:29, David Holmes wrote: >>>> Hi Christoph, >>>> >>>> On 22/07/2021 1:07 am, Langer, Christoph wrote: >>>>> Hi, >>>>> >>>>> there's still no traffic on the mailing lists... >>>>> >>>>> It would be much appreciated if you could share an update on the >>>>> status. >>>> >>>> There was no update to share I'm afraid but it has now been resolved. >>>> >>>> It seems likely that the missing mail is gone forever unfortunately. >>>> >>>> Cheers, >>>> David >>>> >>>>> Thanks >>>>> Christoph >>>>> >>>>> From: Langer, Christoph >>>>> Sent: Dienstag, 20. Juli 2021 08:23 >>>>> To: ops at openjdk.java.net; skara-dev at openjdk.java.net; >>>>> jdk-dev at openjdk.java.net >>>>> Subject: GitHub/Mailing list communication defunct? >>>>> >>>>> Hi, >>>>> >>>>> I just recognized that all of a sudden the traffic on the OpenJDK >>>>> mailing lists dropped... First I thought it's an issue with my >>>>> account but looking at the pipermail archives, I don't find any >>>>> mails after e.g. some time yesterday. And I guess there's still the >>>>> usual activity on GitHub... >>>>> >>>>> Are you aware of an issue? >>>>> >>>>> Thanks & Best regards >>>>> Christoph >>>>> >>> >> > From david.holmes at oracle.com Thu Aug 12 02:23:16 2021 From: david.holmes at oracle.com (David Holmes) Date: Thu, 12 Aug 2021 12:23:16 +1000 Subject: [External] : Re: GitHub/Mailing list communication defunct? In-Reply-To: <35752964-122b-a857-9002-ea8d6e38ae27@oracle.com> References: <095fc050-dbb1-107d-eac9-89c974ba42b8@oracle.com> <59dd2185-104f-3235-6d8a-5f581f6d99be@gmail.com> <35752964-122b-a857-9002-ea8d6e38ae27@oracle.com> Message-ID: On 11/08/2021 4:51 am, Kevin Rushforth wrote: > [Moving jdk-dev to Bcc] Which caused this response to get mis-filed in my email folders so I only must saw it :( > Shah deployed a tentative fix for this about an hour ago. We hope this > will resolve the problem. Unfortunately it didn't. David > -- Kevin > > > On 7/27/2021 10:44 AM, tim.bell at oracle.com wrote: >> Hello >> >>> if someone comments/replies directly to the mailing list thread (like >>> Bernd and I did, during this past hour[2]), those comments aren't >>> being registered in that github PR. This used to work previously and >>> seems to be broken right now. >> >> We are aware of this problem and still investigating.? We don't have a >> root cause or an ETA for this. >> >> Tim >> >> >> On 7/22/21 09:21, Jaikiran Pai wrote: >>> FWIW, it looks like this isn't fully back to normal. From what I can >>> see in one of the PR's[1] I'm involved in, if I comment directly on >>> the PR through the github UI, a mail is now getting delivered to the >>> relevant mailing lists. So this part is back to normal now. >>> >>> However, if someone comments/replies directly to the mailing list >>> thread (like Bernd and I did, during this past hour[2]), those >>> comments aren't being registered in that github PR. This used to work >>> previously and seems to be broken right now. >>> >>> [1] >>> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/4607__;!!ACWV5N9M2RV99hQ!eNjD04SNNH9INHTt0cyyed12lRNw9aZfSspNKh0ILIUQCIcvka-_vJ8XHXipGIQ$ >>> >>> [2] >>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079994.html >>> >>> >>> >>> -Jaikiran >>> >>> On 22/07/21 3:03 am, tim.bell at oracle.com wrote: >>>>> just recognized that all of a sudden the traffic on the OpenJDK >>>>> mailing lists dropped >>>> >>>> About an hour ago we corrected a problem on the Skara server >>>> processing external (EG: github) messages.? Message traffic should >>>> be flowing again. >>>> >>>> Messages for events during the outage are lost.? We will be holding >>>> a port-mortem to investigate why this outage was not noticed sooner, >>>> and why there was a data loss. >>>> >>>> Tim >>>> >>>> >>>> On 7/21/21 14:29, David Holmes wrote: >>>>> Hi Christoph, >>>>> >>>>> On 22/07/2021 1:07 am, Langer, Christoph wrote: >>>>>> Hi, >>>>>> >>>>>> there's still no traffic on the mailing lists... >>>>>> >>>>>> It would be much appreciated if you could share an update on the >>>>>> status. >>>>> >>>>> There was no update to share I'm afraid but it has now been resolved. >>>>> >>>>> It seems likely that the missing mail is gone forever unfortunately. >>>>> >>>>> Cheers, >>>>> David >>>>> >>>>>> Thanks >>>>>> Christoph >>>>>> >>>>>> From: Langer, Christoph >>>>>> Sent: Dienstag, 20. Juli 2021 08:23 >>>>>> To: ops at openjdk.java.net; skara-dev at openjdk.java.net; >>>>>> jdk-dev at openjdk.java.net >>>>>> Subject: GitHub/Mailing list communication defunct? >>>>>> >>>>>> Hi, >>>>>> >>>>>> I just recognized that all of a sudden the traffic on the OpenJDK >>>>>> mailing lists dropped... First I thought it's an issue with my >>>>>> account but looking at the pipermail archives, I don't find any >>>>>> mails after e.g. some time yesterday. And I guess there's still >>>>>> the usual activity on GitHub... >>>>>> >>>>>> Are you aware of an issue? >>>>>> >>>>>> Thanks & Best regards >>>>>> Christoph >>>>>> >>>> >>> >> > From kcr at openjdk.java.net Tue Aug 24 18:02:20 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 24 Aug 2021 18:02:20 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated Message-ID: As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. I didn't add any new tests for this case, so I'll file a follow-up issue. ------------- Commit messages: - 1133: Source branch for /backport PRs is outdated Changes: https://git.openjdk.java.net/skara/pull/1209/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1209&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1133 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/1209.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1209/head:pull/1209 PR: https://git.openjdk.java.net/skara/pull/1209 From kcr at openjdk.java.net Tue Aug 24 18:07:18 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 24 Aug 2021 18:07:18 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v2] In-Reply-To: References: Message-ID: > As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. > > I didn't add any new tests for this case, so I'll file a follow-up issue. Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: empty commit to trigger GitHub Actions ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/1209/files - new: https://git.openjdk.java.net/skara/pull/1209/files/9af73e56..8cb4244d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1209&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1209&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/1209.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1209/head:pull/1209 PR: https://git.openjdk.java.net/skara/pull/1209 From ihse at openjdk.java.net Thu Aug 26 11:33:56 2021 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 26 Aug 2021 11:33:56 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v2] In-Reply-To: References: Message-ID: <5qJp4h3c3TbkLqS1DlaiMvtiOmU3RyMQrU4NGwGgrjE=.517abe7b-f3cd-48df-b044-40d9b327b117@github.com> On Tue, 24 Aug 2021 18:07:18 GMT, Kevin Rushforth wrote: >> As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. >> >> I didn't add any new tests for this case, so I'll file a follow-up issue. > > Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: > > empty commit to trigger GitHub Actions Marked as reviewed by ihse (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/1209 From erikj at openjdk.java.net Fri Aug 27 19:55:12 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Fri, 27 Aug 2021 19:55:12 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v2] In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 18:07:18 GMT, Kevin Rushforth wrote: >> As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. >> >> I didn't add any new tests for this case, so I'll file a follow-up issue. > > Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: > > empty commit to trigger GitHub Actions Good catch! Looks good, but can be cleaned up a little bit. bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 127: > 125: .materialize(targetRepo, localRepoDir); > 126: var fetchHead = localRepo.fetch(bot.repo().url(), hash.hex(), false); > 127: localRepo.checkout(targetBranch); I think this line can be removed. ------------- PR: https://git.openjdk.java.net/skara/pull/1209 From kcr at openjdk.java.net Fri Aug 27 20:05:42 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 27 Aug 2021 20:05:42 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v3] In-Reply-To: References: Message-ID: <07rNp3beFGLLkSmRpmKARhxosfY6otB83gm0x6-MsnQ=.7d6fbb15-12c0-4859-bd7f-fb1cd724931b@github.com> > As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. > > I didn't add any new tests for this case, so I'll file a follow-up issue. Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: Address review coments ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/1209/files - new: https://git.openjdk.java.net/skara/pull/1209/files/8cb4244d..4f24176d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1209&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1209&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/1209.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1209/head:pull/1209 PR: https://git.openjdk.java.net/skara/pull/1209 From kcr at openjdk.java.net Fri Aug 27 20:05:42 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 27 Aug 2021 20:05:42 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v2] In-Reply-To: References: Message-ID: On Fri, 27 Aug 2021 19:51:33 GMT, Erik Joelsson wrote: >> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: >> >> empty commit to trigger GitHub Actions > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/BackportCommand.java line 127: > >> 125: .materialize(targetRepo, localRepoDir); >> 126: var fetchHead = localRepo.fetch(bot.repo().url(), hash.hex(), false); >> 127: localRepo.checkout(targetBranch); > > I think this line can be removed. indeed. ------------- PR: https://git.openjdk.java.net/skara/pull/1209 From erikj at openjdk.java.net Fri Aug 27 20:10:09 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Fri, 27 Aug 2021 20:10:09 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v3] In-Reply-To: <07rNp3beFGLLkSmRpmKARhxosfY6otB83gm0x6-MsnQ=.7d6fbb15-12c0-4859-bd7f-fb1cd724931b@github.com> References: <07rNp3beFGLLkSmRpmKARhxosfY6otB83gm0x6-MsnQ=.7d6fbb15-12c0-4859-bd7f-fb1cd724931b@github.com> Message-ID: On Fri, 27 Aug 2021 20:05:42 GMT, Kevin Rushforth wrote: >> As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. >> >> I didn't add any new tests for this case, so I'll file a follow-up issue. > > Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: > > Address review coments Marked as reviewed by erikj (Lead). ------------- PR: https://git.openjdk.java.net/skara/pull/1209 From kcr at openjdk.java.net Fri Aug 27 20:17:14 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 27 Aug 2021 20:17:14 GMT Subject: Integrated: 1133: Source branch for /backport PRs is outdated In-Reply-To: References: Message-ID: On Tue, 24 Aug 2021 17:58:58 GMT, Kevin Rushforth wrote: > As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. > > I didn't add any new tests for this case, so I'll file a follow-up issue. This pull request has now been integrated. Changeset: 82a58618 Author: Kevin Rushforth URL: https://git.openjdk.java.net/skara/commit/82a586189d7e6f4ca6e172e863561f682da1beec Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 1133: Source branch for /backport PRs is outdated Reviewed-by: ihse, erikj ------------- PR: https://git.openjdk.java.net/skara/pull/1209 From kcr at openjdk.java.net Fri Aug 27 20:20:21 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 27 Aug 2021 20:20:21 GMT Subject: RFR: 1133: Source branch for /backport PRs is outdated [v3] In-Reply-To: <07rNp3beFGLLkSmRpmKARhxosfY6otB83gm0x6-MsnQ=.7d6fbb15-12c0-4859-bd7f-fb1cd724931b@github.com> References: <07rNp3beFGLLkSmRpmKARhxosfY6otB83gm0x6-MsnQ=.7d6fbb15-12c0-4859-bd7f-fb1cd724931b@github.com> Message-ID: On Fri, 27 Aug 2021 20:05:42 GMT, Kevin Rushforth wrote: >> As mentioned in the JBS bug report for this bug, [SKARA-1080](https://bugs.openjdk.java.net/browse/SKARA-1080), which was fixed by PR #1188, was only a partial fix of the problem where the `/backport` command creates the local branch for the PR based off a stale copy of the target branch. The solution is to fetch the target branch from the target repo and base the patch off of that branch. >> >> I didn't add any new tests for this case, so I'll file a follow-up issue. > > Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision: > > Address review coments > I didn't add any new tests for this case, so I'll file a follow-up issue. https://bugs.openjdk.java.net/browse/SKARA-1140 ------------- PR: https://git.openjdk.java.net/skara/pull/1209 From ihse at openjdk.java.net Mon Aug 30 12:25:13 2021 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Mon, 30 Aug 2021 12:25:13 GMT Subject: RFR: 1111: Backport command needs better matching of target repo In-Reply-To: <5zpvudB5ePtwqGe6Afhffaiqa2y7V9FWrXXR8D4RiZM=.aef12434-9503-4efc-a7b2-cfe61c264129@github.com> References: <5zpvudB5ePtwqGe6Afhffaiqa2y7V9FWrXXR8D4RiZM=.aef12434-9503-4efc-a7b2-cfe61c264129@github.com> Message-ID: On Fri, 16 Jul 2021 11:01:48 GMT, Erik Joelsson wrote: > This patch improves the /backport commit command, making it smarter when trying to find the target repository from the argument given by the user. Instead of trying to piece it together based on the namespace (organization/group) of the current repository, it goes straight to the forks configuration and tries to match the repo from there. We can only do backports if there is a valid fork configuration anyway. > > In addition to this, I'm also changing the error message you get when you enter an invalid target repo. The list now includes the namespace prefix for each repo, and a note that supplying it is optional. Marked as reviewed by ihse (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/1204 From ihse at openjdk.java.net Mon Aug 30 12:26:48 2021 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Mon, 30 Aug 2021 12:26:48 GMT Subject: RFR: 1048: Missing integration comment causes mlbridge to throw exceptions In-Reply-To: <4JLVt1HtU-EPf72CyI_ddNzHU9UZ9_ERJBE8rTZucIY=.40c94aaf-a9a0-4323-8fcb-ab4caef555d6@github.com> References: <4JLVt1HtU-EPf72CyI_ddNzHU9UZ9_ERJBE8rTZucIY=.40c94aaf-a9a0-4323-8fcb-ab4caef555d6@github.com> Message-ID: On Fri, 16 Jul 2021 13:19:22 GMT, Erik Joelsson wrote: > This patch changes the mlbridge bot to stop throwing errors when it encounters a PR marked as integrated but without the integration comment (which contains the information about the commit hash needed for the email). Instead, it's just logged and no action is taken. When the comment is eventually added, the bot will run again and the email will be sent. > > The ordering of actions from the PR bot must unfortunately be like it is, with the comment added last. Marked as reviewed by ihse (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/1205 From erikj at openjdk.java.net Mon Aug 30 14:35:12 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Mon, 30 Aug 2021 14:35:12 GMT Subject: Integrated: 1048: Missing integration comment causes mlbridge to throw exceptions In-Reply-To: <4JLVt1HtU-EPf72CyI_ddNzHU9UZ9_ERJBE8rTZucIY=.40c94aaf-a9a0-4323-8fcb-ab4caef555d6@github.com> References: <4JLVt1HtU-EPf72CyI_ddNzHU9UZ9_ERJBE8rTZucIY=.40c94aaf-a9a0-4323-8fcb-ab4caef555d6@github.com> Message-ID: On Fri, 16 Jul 2021 13:19:22 GMT, Erik Joelsson wrote: > This patch changes the mlbridge bot to stop throwing errors when it encounters a PR marked as integrated but without the integration comment (which contains the information about the commit hash needed for the email). Instead, it's just logged and no action is taken. When the comment is eventually added, the bot will run again and the email will be sent. > > The ordering of actions from the PR bot must unfortunately be like it is, with the comment added last. This pull request has now been integrated. Changeset: e8336a41 Author: Erik Joelsson URL: https://git.openjdk.java.net/skara/commit/e8336a41db8d7ccc969bba1505c7b69a1bdc4cfc Stats: 13 lines in 2 files changed: 10 ins; 1 del; 2 mod 1048: Missing integration comment causes mlbridge to throw exceptions Reviewed-by: kcr, ihse ------------- PR: https://git.openjdk.java.net/skara/pull/1205 From erikj at openjdk.java.net Mon Aug 30 14:41:56 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Mon, 30 Aug 2021 14:41:56 GMT Subject: Integrated: 1111: Backport command needs better matching of target repo In-Reply-To: <5zpvudB5ePtwqGe6Afhffaiqa2y7V9FWrXXR8D4RiZM=.aef12434-9503-4efc-a7b2-cfe61c264129@github.com> References: <5zpvudB5ePtwqGe6Afhffaiqa2y7V9FWrXXR8D4RiZM=.aef12434-9503-4efc-a7b2-cfe61c264129@github.com> Message-ID: On Fri, 16 Jul 2021 11:01:48 GMT, Erik Joelsson wrote: > This patch improves the /backport commit command, making it smarter when trying to find the target repository from the argument given by the user. Instead of trying to piece it together based on the namespace (organization/group) of the current repository, it goes straight to the forks configuration and tries to match the repo from there. We can only do backports if there is a valid fork configuration anyway. > > In addition to this, I'm also changing the error message you get when you enter an invalid target repo. The list now includes the namespace prefix for each repo, and a note that supplying it is optional. This pull request has now been integrated. Changeset: 6a76a146 Author: Erik Joelsson URL: https://git.openjdk.java.net/skara/commit/6a76a146b39656e441f0c6c15727737d399ce16e Stats: 48 lines in 4 files changed: 10 ins; 17 del; 21 mod 1111: Backport command needs better matching of target repo Reviewed-by: kcr, ihse ------------- PR: https://git.openjdk.java.net/skara/pull/1204 From erikj at openjdk.java.net Mon Aug 30 17:22:15 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Mon, 30 Aug 2021 17:22:15 GMT Subject: RFR: 1144: Recreated tag causes HostedRepositoryPool to fail fetch Message-ID: This patch makes it possible to force an update of a tag in a Repository as well as forcing fetching of an updated tag. This is then used in the HostedRepositoryPool to avoid errors when a tag has been updated in a repository, which is currently preventing bots from operating on such repositories. ------------- Commit messages: - SKARA-1144 Changes: https://git.openjdk.java.net/skara/pull/1210/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1210&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1144 Stats: 70 lines in 5 files changed: 60 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/1210.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1210/head:pull/1210 PR: https://git.openjdk.java.net/skara/pull/1210 From erikj at openjdk.java.net Mon Aug 30 20:32:24 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Mon, 30 Aug 2021 20:32:24 GMT Subject: RFR: 1145: NPE in GitHubPullRequest::reviews Message-ID: The core of this change is to fix an NPE in GitHubPullRequest::reviews, which happens when a commit that a review refers to no longer exists (presumably because of a rebase or forced update of the review branch). The introduction of a possible null value in Review::hash has some ripple effects however, so this gets a bit more complicated. I've opted to wrap the return value of Review::hash and ReviewComment::hash with Optional to properly force every caller to handle the situation. I haven't seen this happen for ReviewComment, but I would be surprised if the same thing didn't apply there from the GitHub side. ------------- Commit messages: - SKARA-1145 Changes: https://git.openjdk.java.net/skara/pull/1211/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1211&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1145 Stats: 56 lines in 10 files changed: 30 ins; 0 del; 26 mod Patch: https://git.openjdk.java.net/skara/pull/1211.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1211/head:pull/1211 PR: https://git.openjdk.java.net/skara/pull/1211 From ihse at openjdk.java.net Tue Aug 31 10:50:29 2021 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 31 Aug 2021 10:50:29 GMT Subject: RFR: 1145: NPE in GitHubPullRequest::reviews In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 20:28:32 GMT, Erik Joelsson wrote: > The core of this change is to fix an NPE in GitHubPullRequest::reviews, which happens when a commit that a review refers to no longer exists (presumably because of a rebase or forced update of the review branch). The introduction of a possible null value in Review::hash has some ripple effects however, so this gets a bit more complicated. > > I've opted to wrap the return value of Review::hash and ReviewComment::hash with Optional to properly force every caller to handle the situation. I haven't seen this happen for ReviewComment, but I would be surprised if the same thing didn't apply there from the GitHub side. Marked as reviewed by ihse (Reviewer). forge/src/main/java/org/openjdk/skara/forge/Review.java line 62: > 60: /** > 61: * The hash for the commit for which this review was created. Can be null if the commit > 62: * no longer exists. I think technically the Optional is empty, rather than "null". forge/src/main/java/org/openjdk/skara/forge/ReviewComment.java line 55: > 53: /** > 54: * The hash for the commit for which this review comment was created. Can be null if the commit > 55: * no longer exists. Same here... ------------- PR: https://git.openjdk.java.net/skara/pull/1211 From ihse at openjdk.java.net Tue Aug 31 11:21:47 2021 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Tue, 31 Aug 2021 11:21:47 GMT Subject: RFR: 1144: Recreated tag causes HostedRepositoryPool to fail fetch In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 17:18:34 GMT, Erik Joelsson wrote: > This patch makes it possible to force an update of a tag in a Repository as well as forcing fetching of an updated tag. This is then used in the HostedRepositoryPool to avoid errors when a tag has been updated in a repository, which is currently preventing bots from operating on such repositories. Marked as reviewed by ihse (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/1210 From kcr at openjdk.java.net Tue Aug 31 12:11:41 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 31 Aug 2021 12:11:41 GMT Subject: RFR: 1144: Recreated tag causes HostedRepositoryPool to fail fetch In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 17:18:34 GMT, Erik Joelsson wrote: > This patch makes it possible to force an update of a tag in a Repository as well as forcing fetching of an updated tag. This is then used in the HostedRepositoryPool to avoid errors when a tag has been updated in a repository, which is currently preventing bots from operating on such repositories. Marked as reviewed by kcr (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/1210 From erikj at openjdk.java.net Tue Aug 31 12:44:30 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 31 Aug 2021 12:44:30 GMT Subject: RFR: 1145: NPE in GitHubPullRequest::reviews In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 10:46:03 GMT, Magnus Ihse Bursie wrote: >> The core of this change is to fix an NPE in GitHubPullRequest::reviews, which happens when a commit that a review refers to no longer exists (presumably because of a rebase or forced update of the review branch). The introduction of a possible null value in Review::hash has some ripple effects however, so this gets a bit more complicated. >> >> I've opted to wrap the return value of Review::hash and ReviewComment::hash with Optional to properly force every caller to handle the situation. I haven't seen this happen for ReviewComment, but I would be surprised if the same thing didn't apply there from the GitHub side. > > forge/src/main/java/org/openjdk/skara/forge/Review.java line 62: > >> 60: /** >> 61: * The hash for the commit for which this review was created. Can be null if the commit >> 62: * no longer exists. > > I think technically the Optional is empty, rather than "null". Right, in my mind I was documenting the state of the field rather than the return value of the method. I can change it. ------------- PR: https://git.openjdk.java.net/skara/pull/1211 From erikj at openjdk.java.net Tue Aug 31 12:48:13 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 31 Aug 2021 12:48:13 GMT Subject: RFR: 1145: NPE in GitHubPullRequest::reviews [v2] In-Reply-To: References: Message-ID: > The core of this change is to fix an NPE in GitHubPullRequest::reviews, which happens when a commit that a review refers to no longer exists (presumably because of a rebase or forced update of the review branch). The introduction of a possible null value in Review::hash has some ripple effects however, so this gets a bit more complicated. > > I've opted to wrap the return value of Review::hash and ReviewComment::hash with Optional to properly force every caller to handle the situation. I haven't seen this happen for ReviewComment, but I would be surprised if the same thing didn't apply there from the GitHub side. Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: Corrected comment ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/1211/files - new: https://git.openjdk.java.net/skara/pull/1211/files/dcbc4f1c..785376c2 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1211&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1211&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/1211.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1211/head:pull/1211 PR: https://git.openjdk.java.net/skara/pull/1211 From erikj at openjdk.java.net Tue Aug 31 19:11:42 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 31 Aug 2021 19:11:42 GMT Subject: Integrated: 1145: NPE in GitHubPullRequest::reviews In-Reply-To: References: Message-ID: <528cSHFWdJUdtjm7O9HQl2f67g57TPVYdXibP9HHqVE=.0c455329-86b7-423c-be9c-01834952001a@github.com> On Mon, 30 Aug 2021 20:28:32 GMT, Erik Joelsson wrote: > The core of this change is to fix an NPE in GitHubPullRequest::reviews, which happens when a commit that a review refers to no longer exists (presumably because of a rebase or forced update of the review branch). The introduction of a possible null value in Review::hash has some ripple effects however, so this gets a bit more complicated. > > I've opted to wrap the return value of Review::hash and ReviewComment::hash with Optional to properly force every caller to handle the situation. I haven't seen this happen for ReviewComment, but I would be surprised if the same thing didn't apply there from the GitHub side. This pull request has now been integrated. Changeset: 14015529 Author: Erik Joelsson URL: https://git.openjdk.java.net/skara/commit/140155295b523a02b331ca3ba85dcb20d3527fc7 Stats: 56 lines in 10 files changed: 30 ins; 0 del; 26 mod 1145: NPE in GitHubPullRequest::reviews Reviewed-by: ihse ------------- PR: https://git.openjdk.java.net/skara/pull/1211 From erikj at openjdk.java.net Tue Aug 31 19:12:21 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 31 Aug 2021 19:12:21 GMT Subject: Integrated: 1144: Recreated tag causes HostedRepositoryPool to fail fetch In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 17:18:34 GMT, Erik Joelsson wrote: > This patch makes it possible to force an update of a tag in a Repository as well as forcing fetching of an updated tag. This is then used in the HostedRepositoryPool to avoid errors when a tag has been updated in a repository, which is currently preventing bots from operating on such repositories. This pull request has now been integrated. Changeset: 34c770a9 Author: Erik Joelsson URL: https://git.openjdk.java.net/skara/commit/34c770a94b5bdebd9005fd4fa9840017ff6d694c Stats: 70 lines in 5 files changed: 60 ins; 0 del; 10 mod 1144: Recreated tag causes HostedRepositoryPool to fail fetch Reviewed-by: ihse, kcr ------------- PR: https://git.openjdk.java.net/skara/pull/1210 From kcr at openjdk.java.net Tue Aug 31 19:12:18 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 31 Aug 2021 19:12:18 GMT Subject: RFR: 1148: Emails on mailing lists are not posted to GitHub PR In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 19:06:29 GMT, Erik Joelsson wrote: > For a bit over a month, the mlbridge bot seems to be having trouble posting emails as comments in PRs. Especially the hotspot-dev list has been experiencing this. This patch should fix that problem. > > The reading of the mailing list archives happens in MailmanListReader::conversations. There we loop over mailing lists and months. If a particular archive file (combo of mailing list and month) does not exist, the inner loop breaks. This break is the bug. In our case, the mailing list ide-support-dev does not have any emails for August and (I think because of that) the URL https://mail.openjdk.java.net/pipermail/ide-support-dev/2021-August.txt returns 404. This is triggering the break, which is stopping the inner loop (which loops over mailing lists) so it never gets to hotspot-dev (and a few others). > > Looking at the history, this broke in SKARA-843, where the inner loop was added. The break statements then started acting on the wrong loop. > > I'm also improving some log messages which I needed while debugging this. Looks good. ------------- Marked as reviewed by kcr (Reviewer). PR: https://git.openjdk.java.net/skara/pull/1212 From erikj at openjdk.java.net Tue Aug 31 19:12:18 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 31 Aug 2021 19:12:18 GMT Subject: RFR: 1148: Emails on mailing lists are not posted to GitHub PR Message-ID: For a bit over a month, the mlbridge bot seems to be having trouble posting emails as comments in PRs. Especially the hotspot-dev list has been experiencing this. This patch should fix that problem. The reading of the mailing list archives happens in MailmanListReader::conversations. There we loop over mailing lists and months. If a particular archive file (combo of mailing list and month) does not exist, the inner loop breaks. This break is the bug. In our case, the mailing list ide-support-dev does not have any emails for August and (I think because of that) the URL https://mail.openjdk.java.net/pipermail/ide-support-dev/2021-August.txt returns 404. This is triggering the break, which is stopping the inner loop (which loops over mailing lists) so it never gets to hotspot-dev (and a few others). Looking at the history, this broke in SKARA-843, where the inner loop was added. The break statements then started acting on the wrong loop. I'm also improving some log messages which I needed while debugging this. ------------- Commit messages: - SKARA-1148 Changes: https://git.openjdk.java.net/skara/pull/1212/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1212&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1148 Stats: 16 lines in 3 files changed: 0 ins; 3 del; 13 mod Patch: https://git.openjdk.java.net/skara/pull/1212.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1212/head:pull/1212 PR: https://git.openjdk.java.net/skara/pull/1212 From erikj at openjdk.java.net Tue Aug 31 20:16:30 2021 From: erikj at openjdk.java.net (Erik Joelsson) Date: Tue, 31 Aug 2021 20:16:30 GMT Subject: RFR: 1129: [REDO] The mlbridge bot occasionally posts the same comments twice on Github Message-ID: Redo of SKARA-1058. The patch is exactly the same as I don't think it was the cause for SKARA-1128. ------------- Commit messages: - SKARA-1129 Changes: https://git.openjdk.java.net/skara/pull/1213/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1213&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-1129 Stats: 38 lines in 10 files changed: 9 ins; 18 del; 11 mod Patch: https://git.openjdk.java.net/skara/pull/1213.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/1213/head:pull/1213 PR: https://git.openjdk.java.net/skara/pull/1213 From kcr at openjdk.java.net Tue Aug 31 20:32:00 2021 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 31 Aug 2021 20:32:00 GMT Subject: RFR: 1129: [REDO] The mlbridge bot occasionally posts the same comments twice on Github In-Reply-To: References: Message-ID: On Tue, 31 Aug 2021 20:12:58 GMT, Erik Joelsson wrote: > Redo of SKARA-1058. The patch is exactly the same as I don't think it was the cause for SKARA-1128. Yes, there is no reason to suppose that the fix for SKARA-1058 caused the mlbridge problem. ------------- Marked as reviewed by kcr (Reviewer). PR: https://git.openjdk.java.net/skara/pull/1213