Integrated: 1145: NPE in GitHubPullRequest::reviews

Erik Joelsson erikj at
Tue Aug 31 19:11:42 UTC 2021

On Mon, 30 Aug 2021 20:28:32 GMT, Erik Joelsson <erikj at> wrote:

> The core of this change is to fix an NPE in GitHubPullRequest::reviews, which happens when a commit that a review refers to no longer exists (presumably because of a rebase or forced update of the review branch). The introduction of a possible null value in Review::hash has some ripple effects however, so this gets a bit more complicated.
> I've opted to wrap the return value of Review::hash and ReviewComment::hash with Optional to properly force every caller to handle the situation. I haven't seen this happen for ReviewComment, but I would be surprised if the same thing didn't apply there from the GitHub side.

This pull request has now been integrated.

Changeset: 14015529
Author:    Erik Joelsson <erikj at>
Stats:     56 lines in 10 files changed: 30 ins; 0 del; 26 mod

1145: NPE in GitHubPullRequest::reviews

Reviewed-by: ihse



More information about the skara-dev mailing list