RFR: 1256: Use stream api to simplify the csr issue lookup [v3]

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Dec 1 13:46:59 UTC 2021

On Wed, 1 Dec 2021 08:00:15 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> This patch adds the common methods `Issue#linksWithRelationships`, `Issue#csrLink` and `Issue#csrIssue` and refactors the code to reduce the loop nested statements by using these common methods.
>> All the existing tests passed.
>> Best Regards,
>> -- Guoxiong
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>   Improve the encapsulation and use the methods of the 'Optional' instead of direct null check

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 139:

> 137:             return Optional.empty();
> 138:         }
> 139:         var csr = jbsIssue.get().links().stream()

... and here as well. It's really unfortunate that we have no good framework for where to place such common functionality. :-(


PR: https://git.openjdk.java.net/skara/pull/1248

More information about the skara-dev mailing list