RFR: 1258: Add review link/details to comments section
erikj at openjdk.java.net
Fri Dec 3 17:15:22 UTC 2021
On Fri, 3 Dec 2021 15:16:36 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> > I don't think we should remove comments when removing links. Issue comments are meant to represent a log of things happening to an Issue. The links section is meant to represent the current valid/relevant links. Removing the link when it's not relevant is good, but removing comments is like editing history and should only be done rare cases. In this situation, I would leave it to the user to clean up if they think it's needed.
> Curently, the method `removeWebLink` will remove the corresponding comment. Please see the code below. The line `request.delete("/comment/" + comment.id()).execute()` will remove the related web link comment.
> Because such comment is related to the weblink, I think this step is reasonable. But removing the arbitrary comment is not good. I agree that we shouldn't provide the api about removing comment.
You are right, I missed this, and thinking more about this, I think it's the correct behavior. That also means we don't need to change anything with regards to removing links in this enhancement.
> > Also, if you add new API calls to various REST providers, those need thorough testing which can be hard to perform. We unfortunately do not have any automated way of testing the interaction between Skara and Github/Gitlab/Jira.
> I noticed it. Hope the automated tests can be built in the future.
I wouldn't know where to start. I have created a couple of manual tests that interact directly with Github and Gitlab for functionality that I added. To run them you need to feed in a properties file with URLs and authentication data. See ManualForgeTests for an example.
More information about the skara-dev