RFR: 1258: Add review link/details to comments section

Erik Joelsson erikj at openjdk.java.net
Fri Dec 3 18:33:38 UTC 2021

On Fri, 3 Dec 2021 18:17:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> > Given this, we could get away with just changing addWebLink as I suggested. However, this would have the effect that also commit links would be added as both comments and links, which the enhancement request did not ask for. That's probably not desired.
> Actually, I _do_ think having both the link and the comment is desired. See the comment from Magnus in the JBS issue (and my comment agreeing with him).

Sorry if I wasn't clear. We do want both link and comment for review links, but not for commit links. My suggested solution would apply to both kinds of links. The enhancement request was only for review links.


PR: https://git.openjdk.java.net/skara/pull/1250

More information about the skara-dev mailing list