RFR: 1258: Add review link/details to comments section

Erik Joelsson erikj at openjdk.java.net
Fri Dec 3 19:04:14 UTC 2021

On Fri, 3 Dec 2021 18:43:38 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> > Given this, we could get away with just changing addWebLink as I suggested. However, this would have the effect that also commit links would be added as both comments and links, which the enhancement request did not ask for. That's probably not desired.
> Do you mean that if we change the method `addWebLink` as you suggested, there will be two similar comments for commit links, which is unexpected?

No, I seem to have mixed things up in this paragraph, please disregard it. There will never be duplicate link comments because #784 fixed that. I think my proposed fix in `addWebLink` should do the trick. To clarify, addWebLink would do the following.

1. If needsSecurity is false, add an IssueLink (same as today)
2. If a comment with this link doesn't already exist, add a comment with the link (new behavior when needsSecurity is false, otherwise same as today)

> I have one thing to confirm. In a confidential issue, when the patch is integrated (commit links), which comment does you see?

You see the first one, as onNewCommit seems to be executing first. I have searched back JBS and the newest bugs with where the second style comment can be found were fixed for JDK 16, so before #784 (in these issues both comments are present).


PR: https://git.openjdk.java.net/skara/pull/1250

More information about the skara-dev mailing list