RFR: 635: Add census link for credited reviewers
Erik Joelsson
erikj at openjdk.java.net
Mon Dec 6 15:56:22 UTC 2021
On Sun, 5 Dec 2021 18:38:05 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> This patch uses the full name and the census link of the credited reviewer so that the `### Reviewers` part can be clearer.
>
> For example, the [PR-6562](https://github.com/openjdk/jdk/pull/6562) has a credited reviewer which is shown as `jbhateja - Committer Added manually`.
>
> After this patch, it will show: `Jatin Bhateja - Committer Added manually`. The full name `Jatin Bhateja` will replace the username `jbhateja`.
>
> If these is a census link, it will show: `[Jatin Bhateja](https://openjdk.java.net/census#jbhateja) - Committer Added manually`.
>
> And the test cases are added.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
Looks good otherwise.
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 403:
> 401: ret.append("@");
> 402: ret.append(user.username());
> 403: ret.append(" (Unknown ");
I think I prefer the original message "no known <namespace> user name / role".
-------------
PR: https://git.openjdk.java.net/skara/pull/1252
More information about the skara-dev
mailing list