RFR: 1258: Add review link/details to comments section

Guoxiong Li gli at openjdk.java.net
Mon Dec 6 16:15:37 UTC 2021

On Mon, 6 Dec 2021 15:27:47 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> You are correct, we have "commitLink": "false" in the configuration for the confidential notifier.

@erikj79 Given this, if we change the method `addWebLink` as you suggested. We may get two comments in public issues because the method `addWebLinkAsComment` can't identify the comment added by the method `onNewCommit`. We need to remove the relate code about adding comment in `onNewCommit`. The related code, which adds both link and comment like `onNewCommit`, need to be removed, too.(I am not sure whether these code exist at other classes)

So I suggest that we can set the config `reviewLink` to `false`, too. And then add the comment or remove the comment when needed or unneeded. It follows the convention : if we need to add both the link and comment, we need to disable the link at the confidential issues.(such as "commitLink": "false").

> If we need to add Issue::removeComment, then only implement it where it's going to be used, which is in JiraIssue. For GithubPullRequest and GitlabMergeRequest, better leave it not implemented than implemented but not tested.



PR: https://git.openjdk.java.net/skara/pull/1250

More information about the skara-dev mailing list