RFR: 596: Allow short-hand syntax for /label command

Erik Joelsson erikj at openjdk.java.net
Tue Dec 7 14:38:23 UTC 2021


On Tue, 7 Dec 2021 14:24:03 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/LabelCommand.java line 123:
>> 
>>> 121: 
>>> 122:     private void printInvalidLabels(List<String> invalidLabels, PullRequestBot bot, PrintWriter reply) {
>>> 123:         reply.println(""); // Intentionally blank line.
>> 
>> Why a blank line? I can't see anything printed before this method is called.
>
> The `@username` will be printed at first. If the invalid labels is more than 2. The output will be:
> 
> 
> @username The label `labelName` is not a valid label.
> The label `labelName` is not a valid label.
> 
> 
> I would like to adjust it to :
> 
> 
> @username
> The label `labelName` is not a valid label.
> The label `labelName` is not a valid label.

Ah, makes sense.

-------------

PR: https://git.openjdk.java.net/skara/pull/1255


More information about the skara-dev mailing list