Integrated: 1269: Handle Jira host with path element in URL

Erik Joelsson erikj at openjdk.java.net
Wed Dec 8 14:41:04 UTC 2021


On Fri, 3 Dec 2021 22:03:02 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The IssueTracker/JiraHost classes in Skara make the assumption that the base URL for Jira is just a hostname with no path elements. In order to use Skara with a Jira instance with a URL that has a path element, this needs to be fixed.
>
> Instead of always basing REST call URLs on the configured base path and appending to it, there are many cases where the URIBuilder::setPath is used, which overwrites any existing path element. This is especially troublesome when combined with using IssueProject::webUrl as the base for these URLs.
>
> I would like to fix this by adding a supported way of getting the base URI from an IssueTracker (IssueTracker::uri), replace all uses of ::webUrl for constructing other URLs with this new call, and replacing all ::setPath with ::appendPath (in IssueTracker/Jira related code).
>
> This change will require all configurations to be careful not to add a trailing slash to the URL for the Jira instance.
>
> I intend to run this for a while in the staging environment to make sure it works.

This pull request has now been integrated.

Changeset: 57c88f57
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/57c88f57681bacb96ba1ded9670562e5faec7943
Stats:     25 lines in 9 files changed: 14 ins; 0 del; 11 mod

1269: Handle Jira host with path element in URL

Reviewed-by: kcr

-------------

PR: https://git.openjdk.java.net/skara/pull/1251


More information about the skara-dev mailing list