RFR: 713: Rename git/pr-approve to git-pr-review

Erik Joelsson erikj at openjdk.java.net
Thu Dec 9 14:42:25 UTC 2021


On Wed, 8 Dec 2021 10:28:31 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
>
> This patch changes the command `git pr approve` to `git pr review` and adds the option `type` to identify the review type `approve`, `request-changes` or `comment`.
>
> I tested this patch in [PR1](https://github.com/openjdk/skara/pull/1) mistakenly. Apology for the wrong operation. And I can't find the right place to test the `git pr` command now.
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong

If you think you have tested this enough, then the change looks good to me.

-------------

Marked as reviewed by erikj (Lead).

PR: https://git.openjdk.java.net/skara/pull/1256



More information about the skara-dev mailing list