RFR: 713: Rename git/pr-approve to git-pr-review
Guoxiong Li
gli at openjdk.java.net
Thu Dec 9 14:48:19 UTC 2021
On Wed, 8 Dec 2021 15:14:05 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Hi all,
>>
>> This patch changes the command `git pr approve` to `git pr review` and adds the option `type` to identify the review type `approve`, `request-changes` or `comment`.
>>
>> I tested this patch in [PR1](https://github.com/openjdk/skara/pull/1) mistakenly. Apology for the wrong operation. And I can't find the right place to test the `git pr` command now.
>>
>> Thanks for taking the time to review.
>>
>> Best Regards,
>> -- Guoxiong
>
> I recommend using the repository https://github.com/openjdk/playground to test your changes. You can create PRs and play around there freely.
@erikj79 Thanks for the review. Could I get your help to sponsor this patch?
-------------
PR: https://git.openjdk.java.net/skara/pull/1256
More information about the skara-dev
mailing list