RFR: 1280: Possible race condition when integrating PR could cause a spurious "Withdrawn" email

Fri Dec 10 23:07:17 UTC 2021

On Fri, 10 Dec 2021 20:31:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Change the order of adding "integrated" label and closing a pull request to avoid a race with the mlbridge bot, which could otherwise mistakenly send out a "withdrawn" message for a PR that is in the process of being integrated.

Looks fine. And I can think of no downside to doing this.

-------------

Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1259