RFR: 1236: Add jcheck option to check for large binary files [v7]

Guoxiong Li gli at openjdk.java.net
Wed Dec 15 12:47:50 UTC 2021

> Hi all,
> This patch adds the large binary file check to the jcheck.
> The corresponding configuration is like the following code. Each key/value in the `[checks "binary"]` is a mapper. The `key` means the file pattern and the `value` means the limited file size. For example, `.*\.bin=200B` means the file which ends with `.bin` should not exceed 200 Bytes.
> [checks]
> error = binary
> [checks "binary"]
> .*.bin=200B
> .*.o=1k
> The limited file size can use one of these several units:  b(Byte), kb(KiloByte), mb(MegaByte), gb(GigaByte). The units is case insensitive, which means the `Kb`, `kB` and `KB` are equals to `kb(KiloByte)`. If the unit is not provided, it defauts to `b(Byte)`. And these is no a unit called `bit`.
> The corresponding test cases are added.
> Best Regards,
> -- Guoxiong

Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:

 - Merge branch 'master' into SKARA-1236
 - Excluded copied and renamed files.
 - Excluded renamed and copied files. Use Git commit information.
 - Fix the output message.
 - Check the renamed/modified binary file.
 - Enable the binary check.
 - Fix copyright.
 - Polish
 - Use simple config. Restore BinaryIssue. Only check the newly added or copied files.
 - Merge branch 'master' into SKARA-1236
 - ... and 3 more: https://git.openjdk.java.net/skara/compare/26f49c36...3b4eb2c3


  - all: https://git.openjdk.java.net/skara/pull/1247/files
  - new: https://git.openjdk.java.net/skara/pull/1247/files/588660cf..3b4eb2c3

 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1247&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1247&range=05-06

  Stats: 547 lines in 21 files changed: 346 ins; 76 del; 125 mod
  Patch: https://git.openjdk.java.net/skara/pull/1247.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1247/head:pull/1247

PR: https://git.openjdk.java.net/skara/pull/1247

More information about the skara-dev mailing list