Integrated: 713: Rename git/pr-approve to git-pr-review

Guoxiong Li gli at openjdk.java.net
Wed Dec 15 13:36:36 UTC 2021


On Wed, 8 Dec 2021 10:28:31 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch changes the command `git pr approve` to `git pr review` and adds the option `type` to identify the review type `approve`, `request-changes` or `comment`.
> 
> I tested this patch in [PR1](https://github.com/openjdk/skara/pull/1) mistakenly. Apology for the wrong operation. And I can't find the right place to test the `git pr` command now.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: 1b06b946
Author:    Guoxiong Li <gli at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/1b06b9462f7517c86d19a9bfd5dda90a9681dfcf
Stats:     216 lines in 4 files changed: 124 ins; 86 del; 6 mod

713: Rename git/pr-approve to git-pr-review

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/skara/pull/1256


More information about the skara-dev mailing list