RFR: 1275: An unknown sub-command gives a confusing error message [v3]

Erik Joelsson erikj at openjdk.java.net
Mon Dec 20 13:33:39 UTC 2021


On Sat, 18 Dec 2021 14:56:43 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> This was meant as a suggestion for this patch. I don't think the current solution is ok to go in.
>> 
>> I'm not sure about the name of the new method, it's hard to come up with a good name for this property of a Command. It's trying to express if the default sub-command is expected to be run with arguments or not, or if it takes arguments at all, but putting all that in a method name becomes quite a mouthful.
>
> What about `defaultCommandWarningEnabled`? Actually, the default sub-command is always invoked if no sub-command is provided. But the warning message are outputted optionally.

Works for me. Thanks.

-------------

PR: https://git.openjdk.java.net/skara/pull/1257


More information about the skara-dev mailing list