RFR: 1275: An unknown sub-command gives a confusing error message

[Guoxiong Li]

On Thu, 9 Dec 2021 14:37:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Hi all,
>> 
>> When using the unknown command, the client will output the unexpected message. For example:
>> 
>> 
>> $ git-pr lis 123
>> 
>> error: unexpected input: 123
>> usage: git-pr [options] [<COMMAND>]
>> 	-h, --help      Show help
>> 	    --verbose   Turn on verbose output
>> 	    --debug     Turn on debugging output
>> 	    --version   Print the version of this tool
>> 
>> 
>> When the client can't identify the sub-command `git-pr lis`, it will execute the default command `git-pr help` and will pass `lis 123` as the argument to the `git-pr help` command. And the `git-pr help` can resolve only one argument, which is `lis` in this example, so it would output `error: unexpected input: 123`.
>> 
>> This patch will output more information to the user:
>> 
>> 
>> $ git-pr lis 123
>> 
>> Can't find the sub-command 'lis', the default sub-command 'help' will be executed.
>> The arguments [lis, 123] will be passed to the default sub-command.
>> 
>> error: unexpected input: 123
>> usage: git-pr [options] [<COMMAND>]
>> 	-h, --help      Show help
>> 	    --verbose   Turn on verbose output
>> 	    --debug     Turn on debugging output
>> 	    --version   Print the version of this tool
>> 
>> 
>> The added information can let the user know why the following output is shown.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> I like the last suggestion much better, but I still don't think it should be printed for `git webrev`. Running webrev without a sub-command is normal procedure and should not result in a warning.

@erikj79 Thanks for your review. Could I get your help to sponsor this patch?

-------------

PR: https://git.openjdk.java.net/skara/pull/1257