Integrated: 1275: An unknown sub-command gives a confusing error message

[Guoxiong Li]

On Wed, 8 Dec 2021 14:17:51 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> When using the unknown command, the client will output the unexpected message. For example:
> 
> 
> $ git-pr lis 123
> 
> error: unexpected input: 123
> usage: git-pr [options] [<COMMAND>]
> 	-h, --help      Show help
> 	    --verbose   Turn on verbose output
> 	    --debug     Turn on debugging output
> 	    --version   Print the version of this tool
> 
> 
> When the client can't identify the sub-command `git-pr lis`, it will execute the default command `git-pr help` and will pass `lis 123` as the argument to the `git-pr help` command. And the `git-pr help` can resolve only one argument, which is `lis` in this example, so it would output `error: unexpected input: 123`.
> 
> This patch will output more information to the user:
> 
> 
> $ git-pr lis 123
> 
> Can't find the sub-command 'lis', the default sub-command 'help' will be executed.
> The arguments [lis, 123] will be passed to the default sub-command.
> 
> error: unexpected input: 123
> usage: git-pr [options] [<COMMAND>]
> 	-h, --help      Show help
> 	    --verbose   Turn on verbose output
> 	    --debug     Turn on debugging output
> 	    --version   Print the version of this tool
> 
> 
> The added information can let the user know why the following output is shown.
> 
> Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

This pull request has now been integrated.

Changeset: 649dd3cf
Author:    Guoxiong Li <gli at openjdk.org>
Committer: Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/649dd3cf73e2feed6ba330966f3d6108e56585f5
Stats:     14 lines in 4 files changed: 7 ins; 0 del; 7 mod

1275: An unknown sub-command gives a confusing error message

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/skara/pull/1257