RFR: 1293: The Skara bot should not add review links or comments to CSR issues

Guoxiong Li gli at openjdk.java.net
Wed Dec 22 12:02:41 UTC 2021


Hi all,

Currently, the review link and comment will be added to the CSR issue because the method `PullRequestWorkItem::parseIssues` get the all the issues from the PR body. This patch excludes the CSR issue and adds a corresponding test case.

And the method `IssueNotifier::pullRequestToTextBrief` creates the following comment body in the jira, because the method `println` prints the line seperator according to the bot server OS. But it seems that the jira can't identify this line seperator. So I adjust this method bu using the class `StringBuilder` instead of `PrintWriter`.


A pull request was submitted for review.

URL: https://git.openjdk.java.net/jfx/pull/548 Date: 2021-06-28 12:13:44 +0000


Thanks for taking the time to review.

Best Regards,
-- Guoxiong

-------------

Commit messages:
 - Fix copyright.
 - 1293: The Skara bot should not add review links or comments to CSR issues

Changes: https://git.openjdk.java.net/skara/pull/1266/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1266&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-1293
  Stats: 70 lines in 3 files changed: 62 ins; 1 del; 7 mod
  Patch: https://git.openjdk.java.net/skara/pull/1266.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1266/head:pull/1266

PR: https://git.openjdk.java.net/skara/pull/1266


More information about the skara-dev mailing list