RFR: 1298: IssueNotifier removes and re-adds review links and comments

Guoxiong Li gli at openjdk.java.net
Sun Dec 26 11:25:32 UTC 2021


Hi all,

When the author of the PR modified the PR body, the Github will store the PR body by using its internal line separator instead of `\n`. The method `parseIssues` can't identify the line separator so that it can't find any issue.

This patch enhances the pattern to let it identify the `\r` as well and the corresponding test case is added.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong

-------------

Commit messages:
 - 1298: IssueNotifier removes and re-adds review links and comments

Changes: https://git.openjdk.java.net/skara/pull/1269/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1269&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-1298
  Stats: 38 lines in 2 files changed: 37 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/1269.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1269/head:pull/1269

PR: https://git.openjdk.java.net/skara/pull/1269


More information about the skara-dev mailing list