RFR: 574: git-info should use info from commit notifications [v3]
Magnus Ihse Bursie
ihse at openjdk.java.net
Mon Feb 15 12:58:47 UTC 2021
> git-info should use info from commit notifications to get the link to the review, not JBS (since not all PR have issues)
>
> This required refactoring to move the hosted repo logic from cli/pr/Utils.java to where it can be accessed by all CLI tools. After some deliberating, I left a bunch of trivial wrappers in cli/pr/Utils.java -- otherwise this change would have touched *all* the files in cli/pr.
>
> Testing: ad hoc testing of "git info" on some arbitrary Skara commits.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
Add test for reviewUrl parsing
-------------
Changes:
- all: https://git.openjdk.java.net/skara/pull/1011/files
- new: https://git.openjdk.java.net/skara/pull/1011/files/d23292da..50d82756
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=skara&pr=1011&range=02
- incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1011&range=01-02
Stats: 92 lines in 3 files changed: 70 ins; 21 del; 1 mod
Patch: https://git.openjdk.java.net/skara/pull/1011.diff
Fetch: git fetch https://git.openjdk.java.net/skara pull/1011/head:pull/1011
PR: https://git.openjdk.java.net/skara/pull/1011
More information about the skara-dev
mailing list