Integrated: 574: git-info should use info from commit notifications

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Feb 17 18:06:53 UTC 2021


On Fri, 12 Feb 2021 14:11:45 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> git-info should use info from commit notifications to get the link to the review, not JBS (since not all PR have issues)
> 
> This required refactoring to move the hosted repo logic from cli/pr/Utils.java to where it can be accessed by all CLI tools. After some deliberating, I left a bunch of trivial wrappers in cli/pr/Utils.java -- otherwise this change would have touched *all* the files in cli/pr.
> 
> Testing: ad hoc testing of "git info" on some arbitrary Skara commits.

This pull request has now been integrated.

Changeset: a8fe187e
Author:    Magnus Ihse Bursie <ihse at openjdk.org>
Committer: Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/a8fe187e
Stats:     410 lines in 7 files changed: 258 ins; 127 del; 25 mod

574: git-info should use info from commit notifications

Reviewed-by: ehelin

-------------

PR: https://git.openjdk.java.net/skara/pull/1011


More information about the skara-dev mailing list