[skara] RFR: pr: fetch commit comments in work item

Robin Westberg rwestberg at openjdk.java.net
Tue Feb 23 14:06:27 UTC 2021

On Tue, 23 Feb 2021 13:59:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that fetches recent commit comments in a separate `WorkItem` for the `PullRequestBot`. This is to ensure that:
> - possible exceptions thrown when fetching recent commit comments do not impact other `WorkItem`s generated by `PullRequestBot.getPeriodicItems`
> - other `WorkItem`s can continue to make progress if the call to `recentCommitComments` takes a long time
> Testing:
> - [x] `make test` passes on Linux x64
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1031

More information about the skara-dev mailing list